fix: make configuration rolldown compatible - #717
Conversation
susnux
added
type: bug
|
/backport to stable1 |
- `PreRenderedAsset.name` is deprecated in rollup and completely removed in rolldown in favor of `PreRenderedAsset.names`. - `manualChunks` is deprecated in rolldown instead we should use `advancedChunks`. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2e63557 to
fc0a308
Compare
st3iny
left a comment
st3iny
left a comment
There was a problem hiding this comment.
I believe this is backwards-compatible?
Code looks good.
yes - its even deprecated in rollup so also good for current state :) |
|
The backport to # Switch to the target branch and update it
git checkout stable1
git pull origin stable1
# Create the new backport branch
git checkout -b backport/717/stable1
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick fc0a3087
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/717/stable1Error: Failed to clone repository: Failed to clone and cache repo: EACCES: permission denied, mkdir '/app/cache/nextcloud-libraries/nextcloud-vite-config' Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable1 |
|
The backport to # Switch to the target branch and update it
git checkout stable1
git pull origin stable1
# Create the new backport branch
git checkout -b backport/717/stable1
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick fc0a3087
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/717/stable1Error: Failed to clone repository: Failed to clone and cache repo: EACCES: permission denied, mkdir '/app/cache/nextcloud-libraries/nextcloud-vite-config' Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable1 |
|
/backport to stable1 |
|
The backport to # Switch to the target branch and update it
git checkout stable1
git pull origin stable1
# Create the new backport branch
git checkout -b backport/717/stable1
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick fc0a3087
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/717/stable1Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud-libraries:backport/717/stable1."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
4 participants
PreRenderedAsset.nameis deprecated in rollup and completely removed in rolldown in favor ofPreRenderedAsset.names.manualChunksis deprecated in rolldown instead we should useadvancedChunks.